Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DocumentationPage localPath property #324

Merged
merged 7 commits into from
Aug 3, 2022

Conversation

caendesilva
Copy link
Member

This property was added to allow automatic categorization based on subdirectory structures, but while keeping the file output in the root output directory (by keeping the slug as a basename). I think it's better to keep a consistent format between models, and thus include the subdirectory in the slug, and instead extract the basename when getting the currentpage property and output path.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #324 (3f267bb) into master (47a9f84) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #324      +/-   ##
============================================
- Coverage     99.85%   99.85%   -0.01%     
+ Complexity      831      830       -1     
============================================
  Files            96       96              
  Lines          2074     2072       -2     
============================================
- Hits           2071     2069       -2     
  Misses            3        3              
Impacted Files Coverage Δ
...ackages/framework/src/Actions/SourceFileParser.php 100.00% <ø> (ø)
...s/framework/src/Models/Pages/DocumentationPage.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review August 3, 2022 13:39
@caendesilva caendesilva merged commit ac74706 into master Aug 3, 2022
@caendesilva caendesilva deleted the refactor-documentationpage-pathsystem branch August 3, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant