Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove body property from Markdown #338

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 4, 2022

About

Since the Markdown body is now strongly typed as a Markdown object, we have duplicate properties for the Markdown body (which is also stored in the Markdown object). This PR removes that.

Before

^ Hyde\Framework\Models\Pages\MarkdownPage^ {#3014
  +markdown: Hyde\Framework\Models\Markdown^ {#3009
    +body: "foo bar"
  }
  +body: "foo bar"
}

After

^ Hyde\Framework\Models\Pages\MarkdownPage^ {#3006
  +markdown: Hyde\Framework\Models\Markdown^ {#3014
    +body: "foo bar"
  }
}

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #338 (5b6eb22) into master (0b5feb0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #338      +/-   ##
============================================
- Coverage     99.85%   99.85%   -0.01%     
  Complexity      831      831              
============================================
  Files            95       95              
  Lines          2051     2050       -1     
============================================
- Hits           2048     2047       -1     
  Misses            3        3              
Impacted Files Coverage Δ
...s/framework/src/Contracts/AbstractMarkdownPage.php 100.00% <ø> (ø)
.../Actions/GeneratesDocumentationSearchIndexFile.php 100.00% <100.00%> (ø)
...ages/framework/src/Concerns/HasTableOfContents.php 100.00% <100.00%> (ø)
...ckages/framework/src/Models/Pages/MarkdownPost.php 100.00% <100.00%> (ø)
...mework/src/Modules/Markdown/MarkdownFileParser.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review August 4, 2022 16:01
@caendesilva caendesilva merged commit 8c1c206 into master Aug 4, 2022
@caendesilva caendesilva deleted the update-pagemodel-properties branch August 4, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants