-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change internal page data structure to use new front matter schema traits #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o front-matter-schemas
caendesilva
changed the title
Add front matter schemas
Change internal page data structure to use new front matter schema traits
Aug 6, 2022
…o front-matter-schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds schemas as described in #258. These schemas define the public facing data shared to the views, intended to be used by the page templates. For example metadata and SEO information.
The schemas are defined using PHP traits, that also hold the actual data, and may also construct them.
Another benefit of this is that we are also less reliant on magic methods and properties. Those offered through the front matter object would only really be needed for ad-hoc data added by the user.
There are more schemas to add than what will be added in this PR. Such as documentation pages and image objects. Everything that can be supplied as front matter should be covered.