Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure pre-computed relative links are retained when rendering new pages #372

Conversation

caendesilva
Copy link
Member

See #371

We must make sure this does not break relative links. We may need to force a recompute of relative links each time the current page property is set.

Originally posted by @caendesilva in #367 (comment)

@caendesilva caendesilva marked this pull request as draft August 8, 2022 11:32
…retained-when-rendering-new-pages' of github.com:hydephp/develop into 371-add-test-to-ensure-pre-computed-relative-links-are-retained-when-rendering-new-pages
@caendesilva caendesilva marked this pull request as ready for review August 8, 2022 11:35
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #372 (76a2b0a) into master (3b0e835) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master      #372   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       861       861           
===========================================
  Files             93        93           
  Lines           2129      2129           
===========================================
  Hits            2129      2129           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 38d77bb into master Aug 8, 2022
@caendesilva caendesilva deleted the 371-add-test-to-ensure-pre-computed-relative-links-are-retained-when-rendering-new-pages branch August 8, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test to ensure pre-computed relative links are retained when rendering new pages
2 participants