Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #366 PageContract needs compile method #379

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Fix #366 PageContract needs compile method #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ The way metadata tags are handled internally is also refactored. The rendered re
- Fix Path property in Image model should be relative to media directory [#359](https://github.com/hydephp/develop/issues/359)
- Fix Add toString method to Image model to get the link [#370](https://github.com/hydephp/develop/issues/370)
- Fix Blog post OpenGraph images must be resolved relatively [#374](https://github.com/hydephp/develop/issues/374)
- Fix PageContract needs compile method [#366]((https://github.com/hydephp/develop/issues/366))


### Security
- in case of vulnerabilities.
Expand Down
7 changes: 7 additions & 0 deletions packages/framework/src/Contracts/PageContract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,13 @@ public function getCurrentPagePath(): string;
*/
public function getRoute(): RouteContract;

/**
* Compile the page into static HTML.
*
* @return string The compiled HTML for the page.
*/
public function compile(): string;

/**
* Get the page title to display in the <head> section's <title> tag.
*
Expand Down