Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #383: Navigation menu titles can't be set in BladeMatter #384

Merged

Conversation

caendesilva
Copy link
Member

This is caused in FindsNavigationDataForPage.php where the front matter is only read for Markdown pages.

if ($this->page instanceof AbstractMarkdownPage) {
    if ($this->page->matter('navigation.title') !== null) {
        return $this->page->matter('navigation.title');
    }

    if ($this->page->matter('title') !== null) {
        return $this->page->matter('title');
    }
}

@caendesilva caendesilva linked an issue Aug 8, 2022 that may be closed by this pull request
@caendesilva caendesilva marked this pull request as ready for review August 8, 2022 19:47
@caendesilva caendesilva merged commit af56c8f into master Aug 8, 2022
@caendesilva caendesilva deleted the 383-navigation-menu-titles-cant-be-set-in-bladematter branch August 8, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation menu titles can't be set in BladeMatter
1 participant