Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to Hyde::image() helper to prefer full URI paths #394

Conversation

caendesilva
Copy link
Member

If true is passed as the second argument, and a base URL is set, the image will be returned with a qualified Absolute URI.

@caendesilva caendesilva marked this pull request as draft August 9, 2022 10:04
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #394 (2b6270d) into master (c16d47d) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #394   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       884       886    +2     
===========================================
  Files             97        97           
  Lines           2173      2175    +2     
===========================================
+ Hits            2173      2175    +2     
Impacted Files Coverage Δ
packages/framework/src/Hyde.php 100.00% <ø> (ø)
packages/framework/src/Foundation/Hyperlinks.php 100.00% <100.00%> (ø)
packages/framework/src/HydeKernel.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@caendesilva caendesilva marked this pull request as ready for review August 9, 2022 10:09
@caendesilva caendesilva merged commit 3127d46 into master Aug 9, 2022
@caendesilva caendesilva deleted the 376-hydeimage-helper-should-have-option-to-use-qualified-uri-links-when-available branch August 9, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyde::image() helper should have option to use qualified URI links when available
1 participant