Code quality improvements #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Scrutinizer: It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
============================================
+ Coverage 99.01% 99.86% +0.84%
+ Complexity 909 908 -1
============================================
Files 100 99 -1
Lines 2235 2233 -2
============================================
+ Hits 2213 2230 +17
+ Misses 22 3 -19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Since we are overriding the getFacadeRoot method this is not used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues discovered by Scrutinizer and adds missing tests