Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shared command logic to base action command class #407

Merged
merged 9 commits into from
Aug 11, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva caendesilva marked this pull request as draft August 11, 2022 15:59
@caendesilva caendesilva force-pushed the move-shared-logic-to-base-class branch from 5485402 to b91f0ae Compare August 11, 2022 15:59
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@d94c8ec). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 931c745 differs from pull request most recent head 38a4426. Consider uploading reports for the commit 38a4426 to get more accurate results

@@            Coverage Diff            @@
##             master     #407   +/-   ##
=========================================
  Coverage          ?   99.82%           
  Complexity        ?      904           
=========================================
  Files             ?      100           
  Lines             ?     2229           
  Branches          ?        0           
=========================================
  Hits              ?     2225           
  Misses            ?        4           
  Partials          ?        0           
Impacted Files Coverage Δ
...framework/src/Commands/HydeBuildRssFeedCommand.php 100.00% <100.00%> (ø)
.../framework/src/Commands/HydeBuildSearchCommand.php 100.00% <100.00%> (ø)
...framework/src/Commands/HydeBuildSitemapCommand.php 100.00% <100.00%> (ø)
packages/framework/src/Concerns/ActionCommand.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review August 11, 2022 16:23
@caendesilva caendesilva merged commit 28d4644 into master Aug 11, 2022
@caendesilva caendesilva deleted the move-shared-logic-to-base-class branch August 11, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants