Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GeneratesDocumentationSearchIndexFile #418

Merged
merged 19 commits into from
Aug 12, 2022

Conversation

caendesilva
Copy link
Member

Refactors and simplifies the action. Also makes the class final and marks it as internal, as it is not intended to be used outside the package nor be extended.

@caendesilva caendesilva linked an issue Aug 12, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #418 (aade541) into master (7773d7c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #418      +/-   ##
============================================
- Coverage     99.95%   99.95%   -0.01%     
+ Complexity      886      884       -2     
============================================
  Files            99       99              
  Lines          2192     2190       -2     
============================================
- Hits           2191     2189       -2     
  Misses            1        1              
Impacted Files Coverage Δ
.../Actions/GeneratesDocumentationSearchIndexFile.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review August 12, 2022 12:11
@caendesilva caendesilva merged commit 9d87258 into master Aug 12, 2022
@caendesilva caendesilva deleted the 404-clean-up-generatesdocumentationsearchindexfile branch August 12, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up GeneratesDocumentationSearchIndexFile
2 participants