Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #399: MarkdownFileParser not using the Hyde path #419

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 12, 2022

To ensure compatibility, converting a local path to an absolute path using Hyde::path() should be done in the very last stage/operation, usually as the file is accessed.

@caendesilva caendesilva linked an issue Aug 12, 2022 that may be closed by this pull request
@caendesilva caendesilva marked this pull request as ready for review August 12, 2022 12:15
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #419 (f5988bc) into master (9d87258) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #419   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
  Complexity      884      884           
=========================================
  Files            99       99           
  Lines          2190     2190           
=========================================
  Hits           2189     2189           
  Misses            1        1           
Impacted Files Coverage Δ
packages/framework/src/Models/MarkdownDocument.php 100.00% <100.00%> (ø)
...ork/src/Modules/DataCollections/DataCollection.php 100.00% <100.00%> (ø)
...mework/src/Modules/Markdown/MarkdownFileParser.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 379c37b into master Aug 12, 2022
@caendesilva caendesilva deleted the 399-markdownfileparser-not-using-the-hyde-path branch August 12, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MarkdownFileParser not using the Hyde path
2 participants