Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unnecessary contracts #428

Merged
merged 11 commits into from
Aug 17, 2022
Merged

Deprecate unnecessary contracts #428

merged 11 commits into from
Aug 17, 2022

Conversation

caendesilva
Copy link
Member

These were originally added because I wrongly assumed the Laravel service container only accepted interfaces when type hinting. These classes aren't intended to be extended in the same ways other contracts are. Thus, having interfaces for these adds undue complexity.

The following interfaces are affected:

  • HydeKernelContract, type hint the HydeKernel::class instead
  • AssetServiceContract, type hint the AssetService::class instead

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #428 (7022fc7) into master (d730d68) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #428   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
  Complexity      915      915           
=========================================
  Files           102      102           
  Lines          2259     2259           
=========================================
  Hits           2258     2258           
  Misses            1        1           
Impacted Files Coverage Δ
packages/framework/src/Hyde.php 100.00% <ø> (ø)
packages/framework/src/Facades/Asset.php 100.00% <100.00%> (ø)
.../framework/src/Foundation/BaseSystemCollection.php 100.00% <100.00%> (ø)
packages/framework/src/Foundation/Filesystem.php 100.00% <100.00%> (ø)
packages/framework/src/HydeKernel.php 100.00% <100.00%> (ø)
packages/framework/src/HydeServiceProvider.php 100.00% <100.00%> (ø)
packages/framework/src/helpers.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit fdce5c9 into master Aug 17, 2022
@caendesilva caendesilva deleted the deprecate-contracts branch August 17, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants