Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HydeKernel code to organized single-used traits #429

Merged
merged 7 commits into from
Aug 26, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 26, 2022

While I'm generally a bit weary of single-use traits (I love them, but feel that they can be a sign that the code needs to be split up into more classes), the HydeKernel is a vital part of the framework and cannot really be split up the same way as other classes can.

This PR moves logic to scoped internal traits in the Foundation\Concerns namespace. This will make it easier to get an overview of what's going on in each domain. This does not affect any of the logic itself or end usage of the framework, just how it is internally structured.

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@266d2cd). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 9c36a11 differs from pull request most recent head 8b63044. Consider uploading reports for the commit 8b63044 to get more accurate results

@@            Coverage Diff            @@
##             master     #429   +/-   ##
=========================================
  Coverage          ?   99.95%           
  Complexity        ?      914           
=========================================
  Files             ?      105           
  Lines             ?     2259           
  Branches          ?        0           
=========================================
  Hits              ?     2258           
  Misses            ?        1           
  Partials          ?        0           
Impacted Files Coverage Δ
...ork/src/Foundation/Concerns/ForwardsFilesystem.php 100.00% <100.00%> (ø)
...ork/src/Foundation/Concerns/ForwardsHyperlinks.php 100.00% <100.00%> (ø)
...rc/Foundation/Concerns/ImplementsStringHelpers.php 100.00% <100.00%> (ø)
packages/framework/src/HydeKernel.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 9f91a20 into master Aug 26, 2022
@caendesilva caendesilva deleted the organize-and-restructure-code branch August 26, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants