-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only enable support files when there are related pages #448
Merged
caendesilva
merged 14 commits into
master
from
443-rss-feed-meta-link-should-not-be-added-if-there-is-not-a-feed
Aug 28, 2022
Merged
Only enable support files when there are related pages #448
caendesilva
merged 14 commits into
master
from
443-rss-feed-meta-link-should-not-be-added-if-there-is-not-a-feed
Aug 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not-a-feed' of github.com:hydephp/develop into 443-rss-feed-meta-link-should-not-be-added-if-there-is-not-a-feed
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=========================================
Coverage 99.95% 99.95%
Complexity 914 914
=========================================
Files 106 106
Lines 2258 2258
=========================================
Hits 2257 2257
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
deleted the
443-rss-feed-meta-link-should-not-be-added-if-there-is-not-a-feed
branch
August 28, 2022 19:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443
This may seem like a big change, but in actuality, these files were not generated when running the standard build command unless the pages existed, so it makes no sense to have links to them in the site.
Comment related to the issue:
Originally posted by @caendesilva in #443 (comment)