Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert GeneratesDocumentationSearchIndex Action into Service #457

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 31, 2022

Original comment:

Convert into Service, and add more strategies, such as slug-only (no file parsing)
which while dumber, would be much faster to compile and take way less space.

See #435

Three main tasks to this

  • Convert GeneratesDocumentationSearchIndex Action into Service
  • Add more strategies, such as slug-only (no file parsing)
  • Use service to house the logic for the full page search file

The action is marked as internal and is not covered by semantic versioning.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #457 (0d31143) into master (788a271) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #457   +/-   ##
=========================================
  Coverage     99.60%   99.60%           
- Complexity      919      921    +2     
=========================================
  Files           109      109           
  Lines          2269     2273    +4     
=========================================
+ Hits           2260     2264    +4     
  Misses            9        9           
Impacted Files Coverage Δ
packages/framework/src/StaticPageBuilder.php 100.00% <ø> (ø)
...work/src/Actions/PostBuildTasks/GenerateSearch.php 100.00% <100.00%> (ø)
...ages/framework/src/Contracts/AbstractBuildTask.php 100.00% <100.00%> (ø)
...mework/src/Services/DocumentationSearchService.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the 435-convert-generatesdocumentationsearchindex-action-into-service-and-add-more-strategies-such-as-slug-only-no-file-parsing branch from b2a78f9 to 41e3996 Compare August 31, 2022 20:04
@caendesilva caendesilva force-pushed the 435-convert-generatesdocumentationsearchindex-action-into-service-and-add-more-strategies-such-as-slug-only-no-file-parsing branch from bfb1f25 to 1dab93e Compare August 31, 2022 20:26
@caendesilva caendesilva marked this pull request as ready for review August 31, 2022 20:32
@caendesilva caendesilva merged commit 9cd7294 into master Aug 31, 2022
@caendesilva caendesilva deleted the 435-convert-generatesdocumentationsearchindex-action-into-service-and-add-more-strategies-such-as-slug-only-no-file-parsing branch August 31, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants