Simplify internal metadata API #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
============================================
- Coverage 99.95% 99.95% -0.01%
+ Complexity 975 974 -1
============================================
Files 112 114 +2
Lines 2418 2409 -9
============================================
- Hits 2417 2408 -9
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
force-pushed
the
code-refactors
branch
from
57dc0ca to
8df248e
Compare
Reference is unnecessary because the argument is neither assigned nor further passed by reference
|
The global metadata bag inherits some helpers that are not really required, maybe we should split out those to a page metadata bag? Also, update release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have two overlapping services handling metadata (actually three since the Site class does some logic), this is of course not good for maintainability.
This PR reduces complexity, refactors the code, and adds a new class called GlobalMetadataBag to shift those responsibilities the area of concerns for the other metadata classes. It also moves some logic from the Meta facade/helper to the Metadatabag class.
The new GlobalMetadataBag class, when filtering duplicates, will see if there is a current page being rendered, and then diff out those to fix #536.