Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the make:page command action #639

Merged
merged 60 commits into from
Nov 3, 2022
Merged

Refactor the make:page command action #639

merged 60 commits into from
Nov 3, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Nov 3, 2022 •
edited
Loading

Refactors the internals of the MakePageCommand and CreatesNewPageSourceFile to use better OOP.

caendesilva and others added 28 commits November 3, 2022 17:08
@caendesilva
Extract helper method
5ef5846
@caendesilva
Convert string interpolation to concatenation
3c5cbd0
@caendesilva
Dynamically get the source path instead of hard coding it
8f647ff
@caendesilva
Shorten test file name
e76eab2
@caendesilva
Add test helper to assert ignoring carriage returns
474aa07
@caendesilva
Use existing testing helper function
de4f0d3
@caendesilva
Test the entire output directly
e353f23
@caendesilva
Expect spaces not tabs
4bac365
@caendesilva
Reformat heredoc
e1602c9
@caendesilva
Extract method
8b75186
@caendesilva
Inline local variable
fcb7a89
@caendesilva
Move directory creation to the specific helper methods
348a2c0
@caendesilva
Replace 'if' with 'match' expression
94345de
@caendesilva
Reorder methods
a8e39c7
@StyleCIBot
Apply fixes from StyleCI
2f872d3
@caendesilva
Make public helper methods protected
8345837
@caendesilva
Replace with traditional property declaration
abad5bb
@caendesilva
Rename helper method to be more semantic
3f966ab
@caendesilva
Move down helper method
e858e4f
@caendesilva
Refactor path handling
d51c965
@caendesilva
Make helper protected
34c1607
@caendesilva
Refactor tests to not rely on protected data
3dfc5e0
@caendesilva
Use file delete directory helper
a525e0a
@StyleCIBot
Apply fixes from StyleCI
8efb56f
@caendesilva
Protect class properties
f481bbb
@caendesilva
Remove unit test that is already implicitly tested
fea2854
@caendesilva
Add output path getter
9fa67eb
@caendesilva
Extract helper method for common code
8cab22f
@codecov
Copy link

codecov bot commented Nov 3, 2022 •
edited
Loading

Codecov Report

Merging #639 (9582707) into master (dce5e9a) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #639   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1014      1018    +4     
===========================================
  Files            125       125           
  Lines           2526      2526           
===========================================
  Hits            2526      2526
Impacted Files Coverage Δ
...framework/src/Console/Commands/MakePageCommand.php 100.00% <100.00%> (ø)
...src/Framework/Actions/CreatesNewPageSourceFile.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

caendesilva and others added 27 commits November 3, 2022 18:36
@caendesilva
Create output path in constructor
a28bb8d
@caendesilva
Rename helper method property
344942b
@caendesilva
Validate type in constructor
697e93a
@caendesilva
Move up method call
1665636
@caendesilva
Unwrap already evaluated condition
a83d8fe
@caendesilva
Inline variable
ed80976
@caendesilva
Rename helper method
9582707
@caendesilva
Make public properties protected
e06d17b
@caendesilva
Remove Copilot comments
1799d1e
@caendesilva
Replace 'if' with 'match' expression
93fa2fc
@caendesilva
Simplify switch
41697b2
@caendesilva
Extract method and inline variable
ba2c7b6
@caendesilva
Rename class property to match conventions
4fd653f
@caendesilva
Add type annotation
b1feab7
@caendesilva
Exception expects selected type not full message
c071304
@caendesilva
Restructure method flow to be more clear
0909814
@caendesilva
Use class property instead of argument
c3d49ea
@caendesilva
Invert default type selection
34593b1
@caendesilva
Refactor type selection logic to make more sense
37934c4
@caendesilva
Unwrap already evaluated condition due to default value
954b4f4
@caendesilva
Wrap to single line
af0cbff
@caendesilva
Remove unnecessary comment
c54bdf3
@caendesilva
Use full closing statement
dfe0108
@caendesilva
Construct title in validateOptions method
34c40cd
@caendesilva
Construct force option in validateOptions method
6c4e73e
@caendesilva
Extract method
00c0f15
@StyleCIBot
Apply fixes from StyleCI
72ab877
@caendesilva caendesilva marked this pull request as ready for review November 3, 2022 18:22
@caendesilva caendesilva merged commit 1efe785 into master Nov 3, 2022
@caendesilva caendesilva deleted the refactor-actions branch November 3, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot