Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow navigation group to be set with category key #642

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

caendesilva
Copy link
Member

Makes so that the following yield the same result, where previously the latter would do nothing.

---
navigation:
  group: Example
---
---
navigation:
  category: Example
---

This saves you having to try to remember which front matter key works, as now both does!

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #642 (0124aad) into master (344450d) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #642   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1021      1022    +1     
===========================================
  Files            125       125           
  Lines           2534      2537    +3     
===========================================
+ Hits            2534      2537    +3     
Impacted Files Coverage Δ
.../src/Framework/Factories/NavigationDataFactory.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 92adcf5 into master Nov 3, 2022
@caendesilva caendesilva deleted the be-more-forgiving-with-navigation-data branch November 3, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant