-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Markdown classes #651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1020 1024 +4
===========================================
Files 126 126
Lines 2544 2551 +7
===========================================
+ Hits 2544 2551 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Click to show WTD guesses that were not quite right
|
This is why I am very happy we have Percy installed. It seems like this has broken parts of the custom Markdown system. Some Markdown parts are not being compiled, it seems to be the custom colored blockquotes and tables, so I think somewhere we lost passing data to the Markdown compiler about the rendered page so we're using the simple Markdown converter instead of the dynamic one. |
…own instead" This reverts commit 7bcae9c.
Refactors Markdown related classes as a lot of these are pretty much as old as the framework itself.
Notable changes:
{{ $content }}
instead of{!! $markdown !!}
)