Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publications feature #667

Merged
merged 37 commits into from
Nov 18, 2022
Merged

Add publications feature #667

merged 37 commits into from
Nov 18, 2022

Conversation

rgasch
Copy link
Contributor

@rgasch rgasch commented Nov 16, 2022

BuildPublicationTypeSiteCommand + related changes (include "blah" publication type)

rgasch added 26 commits November 2, 2022 13:31
# Conflicts:
#	config/app.php
#	rector.php
…matter' + 'markdown' sub-indexes when returning content.
@caendesilva caendesilva marked this pull request as draft November 17, 2022 11:38
@caendesilva caendesilva changed the title Dev Add publications feature Nov 18, 2022
@caendesilva caendesilva self-requested a review November 18, 2022 19:42
@caendesilva caendesilva marked this pull request as ready for review November 18, 2022 19:42
Copy link
Member

@caendesilva caendesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good for the initial proof of concept. Merging into the develop branch, and I'll do a more extensive code review before we create the PR for merging into master. Thanks for all your work on this!

@caendesilva caendesilva merged commit b1f21b2 into hydephp:dev Nov 18, 2022
caendesilva added a commit that referenced this pull request Dec 27, 2022
This was originally contributed by @rgasch in #667 and is cherry-picked to master to resolve #685 (comment)

Co-Authored-By: Robert Gasch <343614+rgasch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants