-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor publications to integrate better with Hyde #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
changed the title
Refactor publications
Refactor publications to integrate better with Hyde
Nov 19, 2022
I think we should update the schema to not include .blade.php as Laravel doesn't recognize view keys that includes those. Right now I'm stripping out the file extension so it still works, but if we remove the suffix from the schema we can also ship stock views like hyde::layouts.post for example. |
caendesilva
force-pushed
the
refactor-publications
branch
from
November 19, 2022 19:04
287634e
to
7687016
Compare
caendesilva
force-pushed
the
refactor-publications
branch
from
November 19, 2022 19:08
862c8ad
to
275299b
Compare
caendesilva
force-pushed
the
refactor-publications
branch
from
November 19, 2022 19:23
7647c6b
to
64f1ad6
Compare
This doesn't change semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the great work @rgasch has done so the changes better integrate within the Hyde core.
Notably, the data has been refactored into a few classes: both the PublicationType class for a stronger OOP experience, and the pages into "real" Hyde page classes that get auto-discovered and fully integrated into Hyde and its build process.
This also means that the build:publications command has been removed as the standard build command now compiles publications as well. The rendering logic in the removed command has been merged into the new individual page classes.
In addition, this change means that the publications can show up in navigation menus, and be linked to using routes. Try running route list command!