Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema properties as class properties for stronger type system #679

Merged
merged 100 commits into from
Nov 21, 2022
Merged

Add schema properties as class properties for stronger type system #679

merged 100 commits into from
Nov 21, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Nov 20, 2022 •
edited
Loading

Refactors for better OOP in the publication internals.

caendesilva and others added 30 commits November 20, 2022 18:37
@caendesilva
Add schema properties as class properties
6f2477a
@caendesilva
Declare property types
d5927af
@caendesilva
Deprecate protected property
d2ade96
@StyleCIBot
Apply fixes from StyleCI
82b858d
@caendesilva
Style
931b420
@caendesilva
Create PublicationTypeTest.php
f7de5de
@caendesilva
Link to the test
9627050
@StyleCIBot
Apply fixes from StyleCI
bc9f061
@caendesilva
Add static PublicationType::fromFile helper method
928d7cc
@caendesilva
Use static helper instead of using new PublicationType
29433a0
@caendesilva
Generate new constructor
34c9022
@caendesilva
Make non schema properties optional for easier mocking
7fed1d9
@caendesilva
Construct all the arguments
dffaf20
@caendesilva
Update get helper method
d5303d9
@caendesilva
Remove resolved todo
5395be2
@caendesilva
Remove deprecated array property and accessors
68f2a74
@caendesilva
Join comma-separated values into a single line
ef87ac9
@caendesilva
Implements JsonSerializable, Arrayable
5c515ac
@caendesilva
Use JsonSerializesArrayable
7e7efe4
@caendesilva
Implement toArray method
f5415f6
@caendesilva
Move up static helper methods
d3020bf
@caendesilva
Import functions
d8bc8c1
@StyleCIBot
Apply fixes from StyleCI
b755695
@caendesilva
Add base test
7d349b3
@caendesilva
Dynamically handle test
e372985
@caendesilva
Test serialization
47195e2
@caendesilva
Test with path information
8690976
@caendesilva
Refactor to handle $schemaFile dynamically
8a638c3
@caendesilva
Refactor test helper to be dynamic
4cf0ee9
@caendesilva
Implement save method
e1811ea
caendesilva and others added 27 commits November 21, 2022 13:07
@caendesilva
Update case
8789b25
@StyleCIBot
Apply fixes from StyleCI
9a48a43
@caendesilva
Use assertEqualsIgnoringLineEndingType
a470002
@caendesilva
Create CreatesNewPublicationTypeSchemaTest.php
593ee68
@caendesilva
Move test to sub namespace
f1ddc23
@caendesilva
Update class PHPDoc
58e1980
@caendesilva
Rename CreatesNewPublicationTypeSchema to CreatesNewPublicationType
5ab2e4e
@caendesilva
Rename test for renamed class
dcad25e
@caendesilva
Implement CreatesNewPublicationTypeTest
ab28eaa
@StyleCIBot
Apply fixes from StyleCI
8feaf25
@caendesilva
Outfile should be absolute
cf0cbf6
@caendesilva
Print message as sprintf with relative path
c7dd3ea
@caendesilva
Refactor to use the PublicationType object
0a5a910
@caendesilva
Remove mkdir handled by save method
fd2aa89
@caendesilva
Implement Jsonable
b2a08cb
@caendesilva
Default to pretty print JSON
7dbf151
@caendesilva
Use toJson helper
d85bd7e
@caendesilva
Inline local array
23683ef
@caendesilva
Move down property assignment
c53be82
@caendesilva
Pass along output style and use it instead of echo
508f0d1
@caendesilva
Remove unused trait
4e50c47
@caendesilva
Clean up imports
5fb5244
@StyleCIBot
Apply fixes from StyleCI
09126ac
@caendesilva
Add linking tag
586bda8
@caendesilva
Expect fixed output
85ff161
@caendesilva
Display finish output
f5251f4
@StyleCIBot
Apply fixes from StyleCI
a2b2244
@caendesilva caendesilva marked this pull request as ready for review November 21, 2022 14:29
@caendesilva caendesilva merged commit 4fe2bb8 into publications-feature Nov 21, 2022
@caendesilva caendesilva deleted the refactor-publications branch November 21, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot