Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publication fields class #681

Merged
merged 34 commits into from
Nov 21, 2022
Merged

Add publication fields class #681

merged 34 commits into from
Nov 21, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Nov 21, 2022 •
edited
Loading

Adds a PublicationType for a stronger type system.

caendesilva and others added 29 commits November 21, 2022 18:38
@caendesilva
Create PublicationField.php
ea76fe8
@caendesilva
Create PublicationFieldTest.php
9ab9899 
Update PublicationField.php
@caendesilva
Add schema keys as class properties
6b26cc6
@caendesilva
Make properties readonly as they can't be persisted directly
e1ffebf
@caendesilva
Add missing strict types declaration to test
dcb54dc
@caendesilva
Generate constructor
a5b18bd
@caendesilva
Implement JsonSerializable, Arrayable
8eb1709
@caendesilva
Reorder properties to put type first
2e404ff
@caendesilva
Extract helper method
a525a0d
@caendesilva
Internally represent min/max values as integers
d774ca6
@caendesilva
Update expectation order
bdda37b
@caendesilva
Refactor to force output be string via magic method
41ec356
@caendesilva
Revert overengineered code
872fb02
@StyleCIBot
Apply fixes from StyleCI
94b2b01
@caendesilva
Fully use int type for what is actually integers
746c3ae
@caendesilva
Allow range values to be null as they are not applicable to all types
fc06508
@caendesilva
Ensure max value can never be less than the min value when both are set
1a050d0
@caendesilva
Add validation method placeholder
9405c80
@caendesilva
Import class
a19151d
@caendesilva
Add class constant for the accepted types
0060624
@caendesilva
Throw exception for invalid type
1c01569
@StyleCIBot
Apply fixes from StyleCI
d7d9e3d
@caendesilva
Promote class properties
b568190
@caendesilva
Update output hint to match code
33da723 
Update MakePublicationTypeCommandTest.php
@caendesilva
Flip '>' (does not change semantics)
6954258
@caendesilva
Add todo
f1116b2
@caendesilva
Add TYPE_LABELS constant
a5fcf05
@caendesilva
Revert "Add TYPE_LABELS constant"
7931225 
This reverts commit 44eaab7.
@caendesilva
Force type to be lowercase internally
fcc3fb6
@caendesilva caendesilva force-pushed the add-publication-fields-class branch from a83f769 to fcc3fb6 Compare November 21, 2022 18:31
@caendesilva caendesilva force-pushed the add-publication-fields-class branch from 3cc8b12 to 94c2865 Compare November 21, 2022 18:39
@caendesilva caendesilva marked this pull request as ready for review November 21, 2022 18:47
@caendesilva caendesilva merged commit 2a02699 into publications-feature Nov 21, 2022
@caendesilva caendesilva deleted the add-publication-fields-class branch November 21, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot