-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable feature to load styles from the TailwindCSS Play CDN #683
Merged
caendesilva
merged 22 commits into
master
from
feature-to-load-tailwind-styles-from-the-playcdn
Nov 22, 2022
Merged
Add configurable feature to load styles from the TailwindCSS Play CDN #683
caendesilva
merged 22 commits into
master
from
feature-to-load-tailwind-styles-from-the-playcdn
Nov 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1050 1052 +2
===========================================
Files 132 132
Lines 2599 2606 +7
===========================================
+ Hits 2599 2606 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This reverts commit 6503e89.
caendesilva
deleted the
feature-to-load-tailwind-styles-from-the-playcdn
branch
November 22, 2022 19:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for faster prototyping without having to set up an asset pipeline.
For a more consistent result we load the actual Tailwind config from file and inject it into the CDN config. The CDN works as a superset so the default assets are still loaded, thus including the base HydePHP styles. Since this is only for local development the extra bandwidth is not a concern as PlayCDN should not be used in production.
Unfortunately it can't also be defined at runtime by passing a flag to the serve command as proposed in the issue #665 as the server is run in in a separate process, though it would be cool to be able to pass flags to the server script.