Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable feature to load styles from the TailwindCSS Play CDN #683

Merged
merged 22 commits into from
Nov 22, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Nov 22, 2022

This allows for faster prototyping without having to set up an asset pipeline.

For a more consistent result we load the actual Tailwind config from file and inject it into the CDN config. The CDN works as a superset so the default assets are still loaded, thus including the base HydePHP styles. Since this is only for local development the extra bandwidth is not a concern as PlayCDN should not be used in production.

Unfortunately it can't also be defined at runtime by passing a flag to the serve command as proposed in the issue #665 as the server is run in in a separate process, though it would be cool to be able to pass flags to the server script.

@caendesilva caendesilva linked an issue Nov 22, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #683 (83fef83) into master (e0b8f28) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #683   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1050      1052    +2     
===========================================
  Files            132       132           
  Lines           2599      2606    +7     
===========================================
+ Hits            2599      2606    +7     
Impacted Files Coverage Δ
packages/framework/src/Facades/Asset.php 100.00% <ø> (ø)
.../framework/src/Framework/Services/AssetService.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review November 22, 2022 18:46
@caendesilva caendesilva marked this pull request as draft November 22, 2022 19:03
@caendesilva caendesilva marked this pull request as ready for review November 22, 2022 19:33
@caendesilva caendesilva merged commit 8b4c587 into master Nov 22, 2022
@caendesilva caendesilva deleted the feature-to-load-tailwind-styles-from-the-playcdn branch November 22, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature to load Tailwind styles from the PlayCDN
2 participants