Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract service helper to base command class #686

Merged

Conversation

caendesilva
Copy link
Member

Moves method PublicationService::askWithValidation() to ValidatingCommand::askWithValidation()

This PR is not breaking as it targets a branch that has not yet been merged into the master branch so none of this code is in the public API yet.

@caendesilva caendesilva force-pushed the extract-service-helper-to-base-command-class branch from dd1d146 to c6c290b Compare November 23, 2022 19:26
@caendesilva caendesilva marked this pull request as ready for review November 23, 2022 22:06
@caendesilva caendesilva merged commit a427943 into publications-feature Nov 23, 2022
@caendesilva caendesilva deleted the extract-service-helper-to-base-command-class branch November 23, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants