Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor create actions to reduce overlapping code and create a more consistent internal API #689

Merged
merged 37 commits into from
Nov 24, 2022
Merged

Refactor create actions to reduce overlapping code and create a more consistent internal API #689

merged 37 commits into from
Nov 24, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Nov 24, 2022 •
edited
Loading

This targets #685 via #688

caendesilva and others added 30 commits November 24, 2022 16:50
@caendesilva
Add strict types declaration
b8b7abd
@caendesilva
Rename interface CreateActionInterface to CreateActionContract
e974520
@caendesilva
Rename namespace Actions\Interfaces to Actions\Contracts
3f4d776
@caendesilva
Create abstract class CreateAction implements CreateActionContract
5986acf 
Update CreateActionContract.php
@caendesilva
Create CreateActionTest.php
b287c97 
Update CreateAction.php
@StyleCIBot
Apply fixes from StyleCI
6b47aef
@caendesilva
Contracted method throws FileConflictException
6e2cd7f
@caendesilva
Add inheritDoc tag
4db6643
@caendesilva
Add helper methods to contract
f62807b
@caendesilva
Add control properties
90570f2
@caendesilva
Implement getOutputPath and force methods
0a7ad82
@caendesilva
Update conflict prediction helpers
8229c29
@caendesilva
Add and update PHPDocs
43072b0
@caendesilva
Add output path setter
67c7b83
@caendesilva
Make setters fluent
42b0d92
@caendesilva
Add abstract protected function handleCreate
640c346
@caendesilva
Implement create() method
acf02bb
@caendesilva
Reorder methods
f5cdc0f
@StyleCIBot
Apply fixes from StyleCI
0352622
@caendesilva
Use helper method instead of duplicate code
a7a04ca
@caendesilva
Filesystem calls should use absolute path
eeee41f
@caendesilva
Add helper to put contents at absolute path
187375c
@caendesilva
Add CreateActionTestClass
1fa759f
@caendesilva
Extract and contract getAbsoluteOutputPath method
e94247d
@caendesilva
Test create method
20db48d
@caendesilva
Use helper instead of repeated code
f387363
@caendesilva
Fully test the class
e3586ac
@StyleCIBot
Apply fixes from StyleCI
1955d2a
@caendesilva
Use InteractsWithDirectories and ensure parent directory exists for s…
7a0cdf6 
…aved file
@StyleCIBot
Apply fixes from StyleCI
89e98fc
@caendesilva caendesilva marked this pull request as ready for review November 24, 2022 17:29
@caendesilva caendesilva merged commit ce5c8fe into refactor-publication-commands Nov 24, 2022
@caendesilva caendesilva deleted the refactor-CreateActionInterface branch November 24, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot