Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static HydePage::get() method to get pages from the page collection #713

Merged
merged 6 commits into from
Nov 27, 2022

Conversation

caendesilva
Copy link
Member

Fixes #709 in conjunction with #712

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #713 (09f4484) into master (28e8ac0) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #713   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1116      1117    +1     
===========================================
  Files            134       134           
  Lines           2735      2737    +2     
===========================================
+ Hits            2735      2737    +2     
Impacted Files Coverage Δ
...amework/src/Framework/Actions/SourceFileParser.php 100.00% <ø> (ø)
packages/framework/src/Pages/Concerns/HydePage.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 943ae13 into master Nov 27, 2022
@caendesilva caendesilva deleted the make-get-static branch November 27, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing HydePage::get() method to be static and return an instance instead of data from within
2 participants