Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing code to 'tag' field type. #716

Merged
merged 13 commits into from
Nov 28, 2022
Prev Previous commit
Next Next commit
Resolve todo
  • Loading branch information
caendesilva committed Nov 28, 2022
commit 1129f6dad1c84895151b6b536c1ede27547e7d82
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,6 @@ protected function captureFieldsDefinitions(): Collection

if ($type < 10) {
do {
// TODO This should only be done for types that can have length restrictions right?
// ANSWER: No, it can also be a value restriction
// - (int: 0 - 2022)
// - (float: 0 - 360)
// - (datetime: 2022-01-01 - 2022-12-31)
$field->min = trim($this->askWithValidation('min', 'Min value (for strings, this refers to string length)', ['required', 'string'], 0));
$field->max = trim($this->askWithValidation('max', 'Max value (for strings, this refers to string length)', ['required', 'string'], 0));
$lengthsValid = true;
Expand Down