Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DynamicPage interface to denote pages without a source file #722

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Add a DynamicPage interface to denote pages without a source file #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9c80eb
Create DynamicPage.php
caendesilva Dec 2, 2022
7b24b74
Add interface PHPDoc
caendesilva Dec 2, 2022
bbbc1e8
PublicationListPage implements DynamicPage
caendesilva Dec 2, 2022
4e726ec
Apply fixes from StyleCI
StyleCIBot Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/framework/src/Framework/Features/Publications/Models/PublicationListPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Hyde\Framework\Features\Publications\PublicationService;
use Hyde\Hyde;
use Hyde\Pages\BladePage;
use Hyde\Support\Contracts\DynamicPage;
use Illuminate\Support\Facades\Blade;
use InvalidArgumentException;
use function str_contains;
Expand All @@ -17,7 +18,7 @@
* @see \Hyde\Pages\PublicationPage
* @see \Hyde\Framework\Testing\Feature\PublicationListPageTest
*/
class PublicationListPage extends BladePage
class PublicationListPage extends BladePage implements DynamicPage
{
public static string $sourceDirectory = '__publications';
public static string $outputDirectory = '';
Expand Down
13 changes: 13 additions & 0 deletions packages/framework/src/Support/Contracts/DynamicPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

declare(strict_types=1);

namespace Hyde\Support\Contracts;

/**
* This interface is used to mark page classes that are dynamically generated (i.e. not based on a source file).
*/
interface DynamicPage
{
//
}