Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the make publication command and add more tests for it #730

Merged
merged 58 commits into from
Dec 4, 2022
Merged

Refactor the make publication command and add more tests for it #730

merged 58 commits into from
Dec 4, 2022

Conversation

caendesilva
Copy link
Member

Mainly refactors to use the built in console helpers from Laravel/Symfony as they are easier to test than custom implementations.

caendesilva and others added 30 commits December 4, 2022 14:22
@caendesilva
Extract method for getting the sort direction
b264e49
@caendesilva
Refactor to use the built in choice helper
903fabd
@caendesilva
Copy over the option labels
33c19c6
@caendesilva
Update MakePublicationTypeCommandTest.php
c7f8eae
@caendesilva
Add back default value
271c74d
@caendesilva
Default to not add another field
c4d891b
@caendesilva
Extract method for getting the sort field
32d1ed2
@caendesilva
Fix wrong order of expected and actual
6da317a
@caendesilva
Refactor to use the built in choice helper
2a197f2
@caendesilva
Replace foreach loop with array_merge
ba5b97d
@caendesilva
Import all used functions
7c32885
@StyleCIBot
Apply fixes from StyleCI
1d19181
@caendesilva
Extract helper methods
03f0d40
@caendesilva
Extract method to get the canonicalField
26fc6a4
@caendesilva
Move up helper method
f16afa2
@caendesilva
Refactor to use the built in choice helper
610e49c
@caendesilva
Cleanup foreach loop and use stronger comparisons
02f8e33
@caendesilva
Simplify selection logic
d5a9074
@caendesilva
Refactor foreach to use collection helpers
693e743
@caendesilva
Remove duplicate message
451643a
@caendesilva
Add temporary verbose check to see code coverage
824e754
@StyleCIBot
Apply fixes from StyleCI
c39db18
@caendesilva
Extract getFieldType method
0e85595
@caendesilva
Split comma-separated values into multiple lines
f285a81
@caendesilva
Breaking: Add sequential array keys for the PublicationFieldType::TYP…
8f4aefc 
…ES constant
@StyleCIBot
Apply fixes from StyleCI
a3e14fa
@caendesilva
Replace match with constant usage
6fcbe57
@caendesilva
Add spacing between constants
ea97f35
@caendesilva
Output error instead of warning for forbidden value usage
47bf214
@caendesilva
Update error message
a84e0c0
@caendesilva caendesilva marked this pull request as ready for review December 4, 2022 17:23
@caendesilva caendesilva marked this pull request as draft December 4, 2022 17:42
caendesilva and others added 14 commits December 4, 2022 18:44
@caendesilva caendesilva marked this pull request as ready for review December 4, 2022 21:21
@caendesilva caendesilva merged commit 0207c7a into publications-feature Dec 4, 2022
@caendesilva caendesilva deleted the refactor-make-publication-command branch December 4, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot