Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract class for pagination settings #732

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 4, 2022

Changes the schema for pagination settings for publication types by putting the settings in a sub-array and using a data object internally. It also changes the sort direction string to be a boolean as I don't see the need for sorting in any other way than asc/desc. All in all this leads to a more consistent and predictable schema and state.

@caendesilva caendesilva force-pushed the extract-class-for-pagination-settings branch from a3be399 to 48469f9 Compare December 5, 2022 11:38
Update CreatesNewPublicationPageTest.php

Update CreatesNewPublicationType.php

Update test-publication-schema.json

Update MakePublicationCommandTest.php

Update MakePublicationTypeCommandTest.php

Update PublicationListPageTest.php

Update PublicationPageTest.php

Update PublicationPageUnitTest.php
@caendesilva caendesilva force-pushed the extract-class-for-pagination-settings branch from 48469f9 to 00f8d49 Compare December 5, 2022 11:40
@caendesilva caendesilva force-pushed the extract-class-for-pagination-settings branch from d416ba1 to 06653d3 Compare December 5, 2022 12:02
Update CreatesNewPublicationType.php

Update CreatesNewPublicationTypeTest.php

Update MakePublicationTypeCommand.php

Update MakePublicationTypeCommandTest.php

Update PublicationTypeTest.php

Update PublicationPageUnitTest.php
@caendesilva caendesilva force-pushed the extract-class-for-pagination-settings branch from 77697c9 to d53e750 Compare December 5, 2022 13:41
@caendesilva caendesilva marked this pull request as ready for review December 5, 2022 13:42
@caendesilva caendesilva merged commit 0dd3229 into publications-feature Dec 5, 2022
@caendesilva caendesilva deleted the extract-class-for-pagination-settings branch December 5, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants