Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate publications seeder #737

Merged
merged 210 commits into from
Dec 22, 2022
Merged

Integrate publications seeder #737

merged 210 commits into from
Dec 22, 2022

Conversation

caendesilva
Copy link
Member

Integrates code from #721

caendesilva and others added 4 commits December 7, 2022 13:42
@caendesilva @rgasch
Create SeedPublicationCommand.php
12e3367 
Co-Authored-By: Robert Gasch <343614+rgasch@users.noreply.github.com>
@caendesilva @rgasch
Create SeedsPublicationFiles.php
f51ab47 
Co-Authored-By: Robert Gasch <343614+rgasch@users.noreply.github.com>
@caendesilva @rgasch
Register the console command
796e79e 
Co-Authored-By: Robert Gasch <343614+rgasch@users.noreply.github.com>
@StyleCIBot @caendesilva
Apply fixes from StyleCI
4849ce8
@caendesilva caendesilva force-pushed the integrate-publications-seeder branch from 7f7fbba to 4849ce8 Compare December 7, 2022 13:54
StyleCIBot and others added 25 commits December 7, 2022 13:54
@StyleCIBot
Apply fixes from StyleCI
9f4202d
@caendesilva
Add todo
325b2a1
@caendesilva
Update messages and PHPDocs
8230638
@caendesilva
Create SeedsPublicationFilesTest.php
a14ed25
@caendesilva
Create SeedPublicationCommandTest.php
5e21948
@StyleCIBot
Apply fixes from StyleCI
d776ca8
@caendesilva
Set up test publication in setup method
c6338a0
@caendesilva
Protect method to match parent
de48532
@caendesilva
Composer require fakerphp/faker
e7c82d2
@caendesilva
Create base test
9d2ec1f
@caendesilva
Add type annotation
05e9f14
@caendesilva
Switch on the enum value
f0d8092
@caendesilva
Only format the slug for storage
901c39d
@caendesilva
Assert file exists using wildcard
d029604
@caendesilva
Extract helper method
55dc3e2
@StyleCIBot
Apply fixes from StyleCI
eb453c9
@caendesilva
Remove unnecessary concatenation
377f7eb
@caendesilva
Test the string type contents
fce12e4
@caendesilva
Write a testing helper method with a simpler expectation API
2cc49ea
@StyleCIBot
Apply fixes from StyleCI
b04fe6f
@caendesilva
Add pubType property to test class
3979950
@caendesilva
Use ?: instead of ?? which is always false
e3a76e6
@caendesilva
Set the fields explicitly for more readable test code
788fb06
@caendesilva
Extract helper method
106f44f
@caendesilva
Assert the files were created before attempting to use possible inval…
d5bac28 
…id array key
caendesilva and others added 23 commits December 22, 2022 16:58
@caendesilva
Inline local variable
951631b
@caendesilva
Extract method
2a739ac
@caendesilva
Extract method
376dbbe
@caendesilva
Refactor control flow to return value for single assignment source
90fb6b9
@caendesilva
Narrow down mixed return type
3404b27
@caendesilva
Replace 'switch' statement with 'match'
3dc5e00
@caendesilva
Match on the enum
8d3452e
@caendesilva
Revert "Match on the enum"
18cec5e 
This reverts commit 8d3452e.
@StyleCIBot
Apply fixes from StyleCI
de0473e
@caendesilva
Join comma-separated values into a single line
a97cc67
@caendesilva
Replace with traditional property declaration
501c755
@caendesilva
Reorder class properties
cf939cc
@caendesilva
Formatting
1fe6e5c
@caendesilva
Remove added newline and inline variable
ec36091
@caendesilva
Construct faker in constructor
8042c7f
@caendesilva
Unwrap unnecessary string interpolation
faab511
@StyleCIBot
Apply fixes from StyleCI
164aea9
@caendesilva
Extract method
90ec53b
@caendesilva
Merge branch 'integrate-publications-seeder' of github.com:hydephp/de…
ce0c3bf 
…velop into integrate-publications-seeder
@caendesilva
Extract methods for all remaining faker calls
e6b63f9
@caendesilva
Fix match indentation
9393a04
@caendesilva
Create simple lorem ipsum generator
e99b3d4 
Array courtesy of https://github.com/lukehaas/getlorem/blob/e845157641ddb7e4696dd2666c92a8165e407f1b/lib/getlorem.js#L33-L81 licensed under the MIT License
@caendesilva
Make lorem ipsum generator private
ff6bb00
@caendesilva caendesilva force-pushed the integrate-publications-seeder branch from 947936d to ff6bb00 Compare December 22, 2022 16:31
@caendesilva
Copy link
Member Author

caendesilva commented Dec 22, 2022 •
edited
Loading

Since I think it's wasteful to add a whole dependency for such a comparatively small feature using so little code, I created a simple faker alternative in e99b3d4

@caendesilva caendesilva force-pushed the integrate-publications-seeder branch from c9bea5c to d1b80b7 Compare December 22, 2022 16:34
@caendesilva caendesilva marked this pull request as ready for review December 22, 2022 16:49
@caendesilva caendesilva merged commit 5c315dc into publications-feature Dec 22, 2022
@caendesilva caendesilva deleted the integrate-publications-seeder branch December 22, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgasch rgasch rgasch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caendesilva @rgasch @StyleCIBot