Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navigation behaviour for nested pages configurable #740

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 8, 2022

Implements the data generation backend for this feature. We are still going to need to actually implement frontend code to support automatic dropdowns.

#669

Say we have a structure like this, where pages are in a directory of their source directory:

_pages/about/foo.md
_pages/about/bar.md

How should Hyde handle the navigation for these pages? Currently they get added to the navigation menu, but maybe they shouldn't? I have a few ideas for improvement, and I think this should be configurable. I am very happy to get input on this, and also which option should be the default.

  1. Add the pages to the navigation menu (current behaviour)
  2. Put them in an automatic dropdown based on the subdirectory name (my fav)
  3. Don't show them at all

@caendesilva caendesilva linked an issue Dec 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@1a998ae). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master      #740   +/-   ##
==========================================
  Coverage          ?   100.00%           
  Complexity        ?      1134           
==========================================
  Files             ?       137           
  Lines             ?      2771           
  Branches          ?         0           
==========================================
  Hits              ?      2771           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
.../src/Framework/Factories/NavigationDataFactory.php 100.00% <100.00%> (ø)
...c/Framework/Features/Navigation/NavigationMenu.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva
Copy link
Member Author

We are still going to need to actually implement frontend code to support automatic dropdowns

@caendesilva caendesilva marked this pull request as ready for review December 8, 2022 15:33
@caendesilva caendesilva merged commit 9437046 into master Dec 8, 2022
@caendesilva caendesilva deleted the make-navigation-behaviour-for-nested-pages-configurable branch December 8, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make navigation behaviour for nested pages configurable
2 participants