Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove range values from publications to reduce complexity #767

Conversation

caendesilva
Copy link
Member

The range validations add a very large amount of complexity. I'm starting to think about how much we really need them. Sure length validation for article descriptions might be good, but do we really need to validate date ranges and integer values? Maybe it would be better to allow arbitrary Laravel validation rules to be specified in the schema file instead of its min/max values.

Originally posted by @caendesilva in #765 (comment)

@caendesilva caendesilva changed the base branch from master to publications-feature December 21, 2022 16:15
@caendesilva caendesilva force-pushed the remove-range-values-from-publications-to-reduce-complexity branch from 0ae250a to f67f899 Compare December 21, 2022 16:22
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #767 (d5e6145) into publications-feature (2df71ac) will increase coverage by 0.27%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature     #767      +/-   ##
==========================================================
+ Coverage                   97.87%   98.14%   +0.27%     
+ Complexity                   2758     1363    -1395     
==========================================================
  Files                         320      160     -160     
  Lines                        7622     3776    -3846     
==========================================================
- Hits                         7460     3706    -3754     
+ Misses                        162       70      -92     
Impacted Files Coverage Δ
...rc/Console/Commands/MakePublicationTypeCommand.php 78.21% <0.00%> (-5.60%) ⬇️
...rk/src/Console/Commands/MakePublicationCommand.php
...rc/Console/Commands/MakePublicationTypeCommand.php
...c/Console/Commands/ValidatePublicationsCommand.php
.../Features/Publications/Models/PublicationField.php
...k/Features/Publications/Models/PublicationType.php
...ework/Features/Navigation/DocumentationSidebar.php
packages/framework/src/Support/Models/Render.php
...src/Framework/Actions/CreatesNewPageSourceFile.php
...ramework/src/Framework/Services/RebuildService.php
... and 153 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review December 21, 2022 16:34
@caendesilva caendesilva merged commit c084c59 into publications-feature Dec 21, 2022
@caendesilva caendesilva deleted the remove-range-values-from-publications-to-reduce-complexity branch December 21, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants