Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the PublicationField class #769

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva caendesilva changed the title Refactor to move publication field class property to argument Simplify the PublicationField class Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #769 (a59de59) into publications-feature (c084c59) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             publications-feature     #769     +/-   ##
=========================================================
  Coverage                   98.14%   98.14%             
+ Complexity                   2726     1363   -1363     
=========================================================
  Files                         320      160    -160     
  Lines                        7552     3778   -3774     
=========================================================
- Hits                         7412     3708   -3704     
+ Misses                        140       70     -70     
Impacted Files Coverage Δ
...c/Console/Commands/ValidatePublicationsCommand.php 100.00% <0.00%> (ø)
...k/Features/Publications/Models/PublicationType.php 92.85% <0.00%> (ø)
.../Features/Publications/Models/PublicationField.php 100.00% <0.00%> (ø)
...c/Console/Commands/ValidatePublicationsCommand.php
.../Features/Publications/Models/PublicationField.php
...k/Features/Publications/Models/PublicationType.php
...Markdown/Processing/CodeblockFilepathProcessor.php
packages/framework/src/Facades/Filesystem.php
...eatures/Publications/Models/PaginationSettings.php
...ures/BuildTasks/PostBuildTasks/GenerateSitemap.php
... and 153 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the refactor-to-move-PublicationField-class-property-to-argument branch from b9ebf74 to e632323 Compare December 21, 2022 17:00
@caendesilva caendesilva force-pushed the refactor-to-move-PublicationField-class-property-to-argument branch from e632323 to 67d20f9 Compare December 21, 2022 17:07
@caendesilva caendesilva marked this pull request as ready for review December 21, 2022 17:13
@caendesilva caendesilva merged commit 07c89b3 into publications-feature Dec 21, 2022
@caendesilva caendesilva deleted the refactor-to-move-PublicationField-class-property-to-argument branch December 21, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants