Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify publication tag handling #770

Merged
merged 20 commits into from
Dec 22, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 22, 2022

Simplifies how publication tags are handled.

Notably:

  • The tagGroup property is now removed. It's assumed the tag group is the same as the publication type's identifier (same as the publication's directory name)
  • Removes the $reload parameter and the caching of tags

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #770 (9709c3c) into publications-feature (031bfc4) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9709c3c differs from pull request most recent head d552077. Consider uploading reports for the commit d552077 to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature     #770      +/-   ##
==========================================================
- Coverage                   98.52%   98.52%   -0.01%     
+ Complexity                   2784     1390    -1394     
==========================================================
  Files                         324      162     -162     
  Lines                        7722     3855    -3867     
==========================================================
- Hits                         7608     3798    -3810     
+ Misses                        114       57      -57     
Impacted Files Coverage Δ
...rk/src/Console/Commands/MakePublicationCommand.php 69.62% <0.00%> (ø)
...ework/Features/Publications/PublicationService.php 100.00% <0.00%> (ø)
.../Features/Publications/Models/PublicationField.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php
...c/Console/Commands/ValidatePublicationsCommand.php
...rk/src/Framework/Actions/SeedsPublicationFiles.php
.../Features/Publications/Models/PublicationField.php
...ework/Features/Publications/PublicationService.php
...ework/src/Framework/Actions/MarkdownFileParser.php
packages/framework/src/Facades/Includes.php
... and 155 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review December 22, 2022 20:09
@caendesilva caendesilva merged commit d160a57 into publications-feature Dec 22, 2022
@caendesilva caendesilva deleted the simplify-publication-tag-handling branch December 22, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants