Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup publication internals #771

Merged
merged 12 commits into from
Dec 22, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 22, 2022

Attempts to narrow down the scope of the massive #685 PR by removing added dependencies and resetting changes not part of the feature scope.

caendesilva and others added 11 commits December 22, 2022 21:22
…plexity

While this package is very nice to use in framework development I don't think the added complexity is justified as I like to keep dependencies light and it's not compatible with Illuminate helpers such as collect()
Also a nice package to have, but adds complexity by having multiple functions
@caendesilva caendesilva force-pushed the publication-internals-cleanup branch 2 times, most recently from fe805ad to 4146ce3 Compare December 22, 2022 20:54
@caendesilva caendesilva force-pushed the publication-internals-cleanup branch from 4146ce3 to 3c46eca Compare December 22, 2022 20:56
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #771 (4146ce3) into publications-feature (d160a57) will not change coverage.
The diff coverage is n/a.

❗ Current head 4146ce3 differs from pull request most recent head 3c46eca. Consider uploading reports for the commit 3c46eca to get more accurate results

@@                    Coverage Diff                    @@
##             publications-feature     #771     +/-   ##
=========================================================
  Coverage                   98.52%   98.52%             
+ Complexity                   2780     1389   -1391     
=========================================================
  Files                         324      162    -162     
  Lines                        7708     3854   -3854     
=========================================================
- Hits                         7594     3797   -3797     
+ Misses                        114       57     -57     
Impacted Files Coverage Δ
...amework/src/Console/Concerns/ValidatingCommand.php 100.00% <0.00%> (ø)
...rc/Framework/Actions/CreatesNewPublicationPage.php 100.00% <0.00%> (ø)
...k/Features/Publications/Models/PublicationType.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php
...src/Console/Commands/MakePublicationTagCommand.php
...rc/Console/Commands/MakePublicationTypeCommand.php
...rk/src/Console/Commands/SeedPublicationCommand.php
...c/Console/Commands/ValidatePublicationsCommand.php
...rk/src/Framework/Actions/Concerns/CreateAction.php
...rc/Framework/Actions/CreatesNewPublicationPage.php
... and 155 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review December 22, 2022 21:02
@caendesilva caendesilva merged commit a4d91e6 into publications-feature Dec 22, 2022
@caendesilva caendesilva deleted the publication-internals-cleanup branch December 22, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants