-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup publication internals #771
Merged
caendesilva
merged 12 commits into
publications-feature
from
publication-internals-cleanup
Dec 22, 2022
Merged
Cleanup publication internals #771
caendesilva
merged 12 commits into
publications-feature
from
publication-internals-cleanup
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plexity While this package is very nice to use in framework development I don't think the added complexity is justified as I like to keep dependencies light and it's not compatible with Illuminate helpers such as collect()
Also a nice package to have, but adds complexity by having multiple functions
caendesilva
force-pushed
the
publication-internals-cleanup
branch
2 times, most recently
from
December 22, 2022 20:54
fe805ad
to
4146ce3
Compare
caendesilva
force-pushed
the
publication-internals-cleanup
branch
from
December 22, 2022 20:56
4146ce3
to
3c46eca
Compare
Codecov Report
@@ Coverage Diff @@
## publications-feature #771 +/- ##
=========================================================
Coverage 98.52% 98.52%
+ Complexity 2780 1389 -1391
=========================================================
Files 324 162 -162
Lines 7708 3854 -3854
=========================================================
- Hits 7594 3797 -3797
+ Misses 114 57 -57 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to narrow down the scope of the massive #685 PR by removing added dependencies and resetting changes not part of the feature scope.