-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the make:publication command class #774
Refactor the make:publication command class #774
Conversation
Codecov Report
@@ Coverage Diff @@
## publications-feature #774 +/- ##
==========================================================
+ Coverage 97.22% 99.32% +2.09%
+ Complexity 2792 1394 -1398
==========================================================
Files 324 162 -162
Lines 7712 3851 -3861
==========================================================
- Hits 7498 3825 -3673
+ Misses 214 26 -188 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
In the last PR I made so that some types could not be selected as canonical when using the make pubType command, however since files can be edited arbitrary, other types can be set manually. I worked around this in 38d02b5 |
…dephp/develop into refactor-MakePublicationCommand-class
…dephp/develop into refactor-MakePublicationCommand-class
This reverts commit 2d03cdf.
Benchmark tells me there's virtually no difference in performance
d52251b
to
b572d07
Compare
No description provided.