Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the make:publication command class #774

Merged
merged 150 commits into from
Dec 26, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Merging #774 (629a345) into publications-feature (6ff5e95) will increase coverage by 2.09%.
The diff coverage is n/a.

❗ Current head 629a345 differs from pull request most recent head 849079e. Consider uploading reports for the commit 849079e to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature     #774      +/-   ##
==========================================================
+ Coverage                   97.22%   99.32%   +2.09%     
+ Complexity                   2792     1394    -1398     
==========================================================
  Files                         324      162     -162     
  Lines                        7712     3851    -3861     
==========================================================
- Hits                         7498     3825    -3673     
+ Misses                        214       26     -188     
Impacted Files Coverage Δ
...rk/src/Console/Commands/MakePublicationCommand.php
...rc/Framework/Actions/CreatesNewPublicationPage.php
...ckages/framework/src/Support/Models/DateString.php
packages/framework/src/Support/Models/Route.php
...work/src/Foundation/Concerns/ManagesHydeKernel.php
...c/Framework/Actions/ConvertsArrayToFrontMatter.php
...k/src/Framework/Views/Components/LinkComponent.php
.../Framework/Features/Blogging/Models/PostAuthor.php
...ackages/framework/src/Markdown/Models/Markdown.php
...rk/src/Framework/Actions/Concerns/CreateAction.php
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva
Copy link
Member Author

In the last PR I made so that some types could not be selected as canonical when using the make pubType command, however since files can be edited arbitrary, other types can be set manually. I worked around this in 38d02b5

@caendesilva caendesilva force-pushed the refactor-MakePublicationCommand-class branch from d52251b to b572d07 Compare December 26, 2022 17:42
@caendesilva caendesilva marked this pull request as ready for review December 26, 2022 18:30
@caendesilva caendesilva merged commit 8a8fec2 into publications-feature Dec 26, 2022
@caendesilva caendesilva deleted the refactor-MakePublicationCommand-class branch December 26, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants