Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CreatesNewPublicationPage action to use the existing YAML converter #775

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva
Copy link
Member Author

caendesilva commented Dec 26, 2022

This is gonna need some normalizing d55d6e3

Edit: Done

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #775 (e32f65c) into publications-feature (6781eb5) will decrease coverage by 1.47%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature     #775      +/-   ##
==========================================================
- Coverage                   98.70%   97.22%   -1.48%     
+ Complexity                   2794     1396    -1398     
==========================================================
  Files                         324      162     -162     
  Lines                        7716     3856    -3860     
==========================================================
- Hits                         7616     3749    -3867     
- Misses                        100      107       +7     
Impacted Files Coverage Δ
...rk/src/Console/Commands/MakePublicationCommand.php 0.00% <0.00%> (-69.63%) ⬇️
...rc/Framework/Actions/CreatesNewPublicationPage.php 94.44% <0.00%> (-5.56%) ⬇️
...rc/Framework/Actions/CreatesNewPublicationPage.php
...work/src/Framework/Concerns/ValidatesExistence.php
...rk/src/Console/Commands/SeedPublicationCommand.php
...Concerns/Internal/ForwardsIlluminateFilesystem.php
...rk/src/Framework/Features/Metadata/MetadataBag.php
...ework/src/Console/Commands/PublishViewsCommand.php
...ckages/framework/src/Foundation/Facades/Router.php
packages/framework/src/Support/Models/Route.php
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review December 26, 2022 16:30
@caendesilva caendesilva merged commit 6ff5e95 into publications-feature Dec 26, 2022
@caendesilva caendesilva deleted the refactor-CreatesNewPublicationPage-to-use-existing-YAML-converter branch December 26, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants