Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate list and detail pages when creating publication types #776

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 26, 2022

    From Robert RE: Generate list and detail pages when creating publication types

That is a good idea, it could just be a simple/stupid template which does

{{ $fieldName}}: {{ $fieldValue}

Maybe something a bit more involved, but some sort of basic generic template which displays the data

Originally posted by @caendesilva in #685 (comment)

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #776 (154b785) into publications-feature (9f238a7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             publications-feature     #776     +/-   ##
=========================================================
  Coverage                   99.35%   99.35%             
+ Complexity                   2786     1398   -1388     
=========================================================
  Files                         324      162    -162     
  Lines                        7698     3865   -3833     
=========================================================
- Hits                         7648     3840   -3808     
+ Misses                         50       25     -25     
Impacted Files Coverage Δ
...rc/Console/Commands/MakePublicationTypeCommand.php 100.00% <0.00%> (ø)
...rc/Framework/Actions/CreatesNewPublicationType.php 100.00% <0.00%> (ø)
...rc/Console/Commands/MakePublicationTypeCommand.php
...rc/Framework/Actions/CreatesNewPublicationType.php
...c/Console/Commands/ValidatePublicationsCommand.php
...amework/src/Console/Concerns/ValidatingCommand.php
packages/framework/src/Foundation/Hyperlinks.php
.../src/Console/Commands/RebuildStaticSiteCommand.php
...rc/Framework/Concerns/InteractsWithDirectories.php
...rc/Console/Commands/Helpers/InputStreamHandler.php
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review December 27, 2022 11:18
@caendesilva caendesilva merged commit ef9563b into publications-feature Dec 27, 2022
@caendesilva caendesilva deleted the generate-list-and-detail-pages-when-creating-publication-types- branch December 27, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants