Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove directoryName prefix from default generated publication templates #777

Merged
merged 8 commits into from
Dec 27, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 27, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #777 (4cbe3f1) into publications-feature (ef9563b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature     #777      +/-   ##
==========================================================
- Coverage                   99.35%   99.35%   -0.01%     
+ Complexity                   2796     1396    -1400     
==========================================================
  Files                         324      162     -162     
  Lines                        7730     3860    -3870     
==========================================================
- Hits                         7680     3835    -3845     
+ Misses                         50       25      -25     
Impacted Files Coverage Δ
...rc/Framework/Actions/CreatesNewPublicationType.php 100.00% <0.00%> (ø)
...rc/Framework/Actions/CreatesNewPublicationType.php
packages/framework/src/Support/Models/Route.php
...ework/Features/Publications/PublicationService.php
...ework/src/Framework/Actions/PublishesHydeViews.php
.../framework/src/Framework/Services/BuildService.php
...rc/Framework/Concerns/InteractsWithFrontMatter.php
...amework/src/Framework/Services/MarkdownService.php
...amework/Features/Blogging/Models/FeaturedImage.php
packages/framework/src/Facades/Site.php
... and 153 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the publications-feature-refactors branch 2 times, most recently from b5226f1 to 1f29180 Compare December 27, 2022 11:55
Update CreatesNewPublicationTypeTest.php

Update MakePublicationTypeCommandTest.php
@caendesilva caendesilva force-pushed the publications-feature-refactors branch from 1f29180 to 26b2104 Compare December 27, 2022 11:57
@caendesilva caendesilva changed the title Publications feature refactors Remove directoryName prefix from default generated publication templates Dec 27, 2022
@caendesilva caendesilva marked this pull request as ready for review December 27, 2022 12:28
@caendesilva caendesilva merged commit de5c0e0 into publications-feature Dec 27, 2022
@caendesilva caendesilva deleted the publications-feature-refactors branch December 27, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants