Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement reloadable choice helper for the validating command class #782

Merged
merged 20 commits into from
Dec 27, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 27, 2022

Refactors, fixes, and integrates, a console choice helper that can reload the choices by evaluating a supplied closure.

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #782 (97249b3) into publications-feature (8e31b0b) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature      #782     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   2794      1399   -1395     
==========================================================
  Files                         324       162    -162     
  Lines                        7014      3510   -3504     
==========================================================
- Hits                         7014      3510   -3504     
Impacted Files Coverage Δ
...amework/src/Console/Concerns/ValidatingCommand.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php
...amework/src/Console/Concerns/ValidatingCommand.php
packages/framework/src/Pages/BladePage.php
packages/framework/src/Foundation/Filesystem.php
...k/Features/Blogging/Models/RemoteFeaturedImage.php
...src/Console/Commands/MakePublicationTagCommand.php
.../framework/src/Framework/Services/BuildService.php
...ork/src/Markdown/Processing/ShortcodeProcessor.php
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva changed the title Publications feature refactors Properly implement reloadable choice helper for the validating command class Dec 27, 2022
@caendesilva caendesilva marked this pull request as ready for review December 27, 2022 17:49
@caendesilva caendesilva merged commit 7a68edd into publications-feature Dec 27, 2022
@caendesilva caendesilva deleted the publications-feature-refactors branch December 27, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants