Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publication page creation internals #793

Merged
merged 38 commits into from
Dec 30, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 30, 2022

Improves the integration between the new publication field classes and the make:publication command and fixes some bugs.

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #793 (faa293b) into publications-feature (399badb) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head faa293b differs from pull request most recent head 6d26e9e. Consider uploading reports for the commit 6d26e9e to get more accurate results

@@                     Coverage Diff                     @@
##             publications-feature      #793      +/-   ##
===========================================================
+ Coverage                   99.94%   100.00%   +0.05%     
  Complexity                   1424      1424              
===========================================================
  Files                         174       174              
  Lines                        3581      3581              
===========================================================
+ Hits                         3579      3581       +2     
+ Misses                          2         0       -2     
Impacted Files Coverage Δ
...rk/src/Console/Commands/MakePublicationCommand.php 100.00% <0.00%> (ø)
...rc/Console/Commands/Helpers/InputStreamHandler.php 100.00% <0.00%> (ø)
...rk/Features/Publications/PublicationFieldTypes.php 100.00% <0.00%> (+8.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva changed the title Refactor publication field classes Improve integration between the new publication field classes and the make:publication command Dec 30, 2022
@caendesilva caendesilva changed the title Improve integration between the new publication field classes and the make:publication command Refactor publication page creation Dec 30, 2022
@caendesilva caendesilva changed the title Refactor publication page creation Refactor publication page creation internals Dec 30, 2022
@caendesilva caendesilva marked this pull request as ready for review December 30, 2022 21:17
@caendesilva caendesilva merged commit edf9e02 into publications-feature Dec 30, 2022
@caendesilva caendesilva deleted the refactor-publication-field-classes branch December 30, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants