Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publication list page to extend virtual page #813

Conversation

caendesilva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #813 (d43963e) into publications-feature (e00294c) will not change coverage.
The diff coverage is n/a.

❗ Current head d43963e differs from pull request most recent head 95b9463. Consider uploading reports for the commit 95b9463 to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature      #813     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   2930      1464   -1466     
==========================================================
  Files                         336       168    -168     
  Lines                        7344      3670   -3674     
==========================================================
- Hits                         7344      3670   -3674     
Impacted Files Coverage Δ
...atures/Publications/Models/PublicationListPage.php 100.00% <0.00%> (ø)
...atures/Publications/Models/PublicationListPage.php
...framework/src/Console/Commands/MakePostCommand.php
...ework/src/Console/Commands/PublishViewsCommand.php
...ckages/framework/src/Foundation/PageCollection.php
...ork/src/Foundation/Concerns/ForwardsFilesystem.php
...ures/BuildTasks/PostBuildTasks/GenerateRssFeed.php
packages/framework/src/Pages/BladePage.php
.../Framework/Services/DocumentationSearchService.php
packages/framework/src/Support/Models/Render.php
... and 159 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the refactor-publication-list-page-to-extend-virtual-page branch from d43963e to 95b9463 Compare January 6, 2023 16:42
@caendesilva caendesilva marked this pull request as ready for review January 6, 2023 16:45
@caendesilva caendesilva merged commit 14fc8da into publications-feature Jan 6, 2023
@caendesilva caendesilva deleted the refactor-publication-list-page-to-extend-virtual-page branch January 6, 2023 16:45
caendesilva added a commit that referenced this pull request Jan 6, 2023
…o-extend-virtual-page

Refactor publication list page to extend virtual page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant