-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor publication types to simplify the code and integrate publication pagination settings #816
Merged
caendesilva
merged 64 commits into
publications-feature
from
improve-make-publication-type-command-to-better-integrate-pagination-settings
Jan 8, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
caendesilva
commented
Jan 8, 2023
•
edited
Loading
edited
- Improves the publication type create command to better integrate pagination settings
- Removes the prevNextLinks setting as it's unlikely one would enable page size limits without a way to traverse them
- Makes the pagination settings property of publication types nullable, whilst also making pagination not be the default
- The publication type constructor now only accepts arrays for the publication setting (to keeps things simple, and since all other arguments are primitive PHP types)
- Change default publication type canonicalField value from identifier to __createdAt as this is what is being null coalesced to in the creator action, plus it matches the pagination defaults
- Refactor internal field data state to be parsed as this makes it impossible to create an invalid schema only to not realize it until later. Also removes the duplicate getters which is just confusing.
caendesilva
force-pushed
the
improve-make-publication-type-command-to-better-integrate-pagination-settings
branch
from
January 8, 2023 14:40
a7ad2f7
to
3617619
Compare
Codecov Report
@@ Coverage Diff @@
## publications-feature #816 +/- ##
==========================================================
Coverage 100.00% 100.00%
+ Complexity 3020 1511 -1509
==========================================================
Files 338 169 -169
Lines 7548 3779 -3769
==========================================================
- Hits 7548 3779 -3769 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
changed the title
Improve the publication type create command to better integrate pagination settings
Simplify and integrate publication pagination settings
Jan 8, 2023
Removed as its unlikely one would enable page size limits without a way to traverse them
caendesilva
force-pushed
the
improve-make-publication-type-command-to-better-integrate-pagination-settings
branch
from
January 8, 2023 15:43
b23fb3e
to
08737e7
Compare
…e-command-to-better-integrate-pagination-settings
…e-command-to-better-integrate-pagination-settings
…e-command-to-better-integrate-pagination-settings
caendesilva
force-pushed
the
improve-make-publication-type-command-to-better-integrate-pagination-settings
branch
from
January 8, 2023 16:53
0197efb
to
b11d39a
Compare
Makes it impossible to create an invalid schema only to not realize it until later. Also removes the duplicate getters which is just confusing.
Since the parsed value is sorted by object
This reverts commit 954a6cf.
…e-command-to-better-integrate-pagination-settings
…refactor"" This reverts commit dd5170b.
… during refactor""" This reverts commit c20eea1.
…ere and add complexity without value They are only expected in a single test file and never actually used. They also don't offer any new information since the name is present within the value.
caendesilva
deleted the
improve-make-publication-type-command-to-better-integrate-pagination-settings
branch
January 8, 2023 19:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.