Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple publications package #827

Merged
merged 50 commits into from
Jan 12, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 11, 2023

Decouples the package from #826 with features from #685 to (re-)allow the framework to function independently without it.

Also moves some extra code missed in #826.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #827 (0f55846) into publications-feature (181f387) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 0f55846 differs from pull request most recent head c4edeaa. Consider uploading reports for the commit c4edeaa to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature     #827      +/-   ##
==========================================================
- Coverage                  100.00%   99.92%   -0.08%     
+ Complexity                   3052     1526    -1526     
==========================================================
  Files                         342      172     -170     
  Lines                        7622     3812    -3810     
==========================================================
- Hits                         7622     3809    -3813     
- Misses                          0        3       +3     
Impacted Files Coverage Δ
...publications/src/Actions/SeedsPublicationFiles.php 98.50% <0.00%> (-1.50%) ⬇️
...p/packages/publications/src/PublicationService.php 100.00% <0.00%> (ø)
...ckages/framework/src/Foundation/PageCollection.php 100.00% <0.00%> (ø)
...ckages/publications/src/Models/PublicationPage.php 100.00% <0.00%> (ø)
...s/publications/src/PublicationsServiceProvider.php 100.00% <0.00%> (ø)
...amework/src/Framework/Actions/SourceFileParser.php 100.00% <0.00%> (ø)
...blications/src/Commands/MakePublicationCommand.php 100.00% <0.00%> (ø)
...blications/src/Commands/SeedPublicationCommand.php 100.00% <0.00%> (ø)
...cations/src/Commands/MakePublicationTagCommand.php 100.00% <0.00%> (ø)
...ations/src/Commands/MakePublicationTypeCommand.php 100.00% <0.00%> (ø)
... and 177 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the decouple-publications-package branch from e5ab940 to 968f770 Compare January 11, 2023 21:12
@caendesilva caendesilva force-pushed the decouple-publications-package branch from d7a4dd8 to 39875d8 Compare January 11, 2023 21:30
@caendesilva caendesilva marked this pull request as ready for review January 12, 2023 09:22
@caendesilva caendesilva merged commit 1e0d218 into publications-feature Jan 12, 2023
@caendesilva caendesilva deleted the decouple-publications-package branch January 12, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants