Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline publication type creation and pagination internals #830

Merged
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
c165bea
Assert the correct template was published
caendesilva Jan 12, 2023
9614992
Remove unnecessary qualifier
caendesilva Jan 12, 2023
989b35f
Update publication type creator to use the paginated view when enabled
caendesilva Jan 12, 2023
72a7be5
Simplify 'if'
caendesilva Jan 12, 2023
ffe4abe
Inline variable
caendesilva Jan 12, 2023
fa2d88c
Convert concatenation to 'sprintf()' call
caendesilva Jan 12, 2023
75cbf10
Move common parts to the helper method
caendesilva Jan 12, 2023
534ff2f
Move common parts to the helper method
caendesilva Jan 12, 2023
bfe9863
Convert 'sprintf()' call to a scalar value
caendesilva Jan 12, 2023
4cbebf3
Join comma-separated values into a single line
caendesilva Jan 12, 2023
a56e607
Move common parts to the helper method
caendesilva Jan 12, 2023
35d4a45
Update helper method parameter name
caendesilva Jan 12, 2023
44648ce
Split comma-separated values into multiple lines
caendesilva Jan 12, 2023
807fda3
Revert "Split comma-separated values into multiple lines"
caendesilva Jan 12, 2023
3eb7536
Rename local helper method
caendesilva Jan 12, 2023
d36dd27
Switch around tests with mismatched names
caendesilva Jan 12, 2023
f28119a
Update virtual page class to support compiling anonymous Blade files
caendesilva Jan 12, 2023
2c147e2
Update virtual page class to support custom closure compiling
caendesilva Jan 12, 2023
5c8ff4d
Pass custom compile function to paginated listing pages
caendesilva Jan 12, 2023
abb1699
Paginated listing views can now be compiled
caendesilva Jan 12, 2023
93b5e40
Apply fixes from StyleCI
StyleCIBot Jan 12, 2023
d4a1e35
Revert "Pass custom compile function to paginated listing pages"
caendesilva Jan 12, 2023
13e1026
Prepend directory prefix for paginated listing pages when needed
caendesilva Jan 12, 2023
c4df021
Set default page size of creator action to nought to match constructor
caendesilva Jan 12, 2023
6acde59
Set default page size of command to nought to match constructor
caendesilva Jan 12, 2023
6f30499
Inline deprecated helper method
caendesilva Jan 13, 2023
b633729
Apply fixes from StyleCI
StyleCIBot Jan 13, 2023
9c24ce3
Update question message
caendesilva Jan 13, 2023
54e05ec
Add temporary markers
caendesilva Jan 13, 2023
323e94e
Remove question regarding enablement of pagination
caendesilva Jan 13, 2023
8d46d83
Remove info output
caendesilva Jan 13, 2023
a170f1c
Inline array list syntax
caendesilva Jan 13, 2023
8908a1b
Simplify if
caendesilva Jan 13, 2023
38f6da5
Update question messages
caendesilva Jan 13, 2023
1b5d77a
Update MakePublicationTypeCommandTest.php
caendesilva Jan 13, 2023
62c1dbe
Remove todo
caendesilva Jan 13, 2023
c28beee
Update question message
caendesilva Jan 13, 2023
935519b
Add console link to the docs
caendesilva Jan 13, 2023
fbcfb12
Update MakePublicationTypeCommandTest.php
caendesilva Jan 13, 2023
d631d65
Extract testing constants for impossibly long messages
caendesilva Jan 13, 2023
4645391
Move up canonical field question
caendesilva Jan 13, 2023
40a4c7b
Grey out question helper messages
caendesilva Jan 13, 2023
58bb8e6
Apply fixes from StyleCI
StyleCIBot Jan 13, 2023
be0ed07
Remove the --use-defaults option to reduce complexity
caendesilva Jan 13, 2023
abe5dde
Return placeholder to support non-interactive inputs
caendesilva Jan 13, 2023
69625a9
Bypass entire method when not interactive
caendesilva Jan 13, 2023
8c0a7ca
The default value should be string to match actual returned type
caendesilva Jan 13, 2023
0a15afa
Add method overrides to support non-interactive prompts
caendesilva Jan 13, 2023
426cb69
Revert "Add method overrides to support non-interactive prompts" as t…
caendesilva Jan 13, 2023
3ae7ebb
Disable output mocking due to presumed vendor bug
caendesilva Jan 13, 2023
3e616ef
Apply fixes from StyleCI
StyleCIBot Jan 13, 2023
c49cd62
Revert type change
caendesilva Jan 13, 2023
53c0243
Update MakePublicationTypeCommandTest.php
caendesilva Jan 13, 2023
ea24df0
Add todo
caendesilva Jan 13, 2023
2bd6199
Non-canonicable fields should not be allowed to be used for sorting
caendesilva Jan 13, 2023
edd586f
Reorder methods to match usage flow
caendesilva Jan 13, 2023
a792b5b
Add assertions on the generated default file
caendesilva Jan 13, 2023
24d757e
Change helper method to void as that changes nothing
caendesilva Jan 13, 2023
544c742
Inline local variable
caendesilva Jan 13, 2023
a6a89b8
Extract method for repeated code
caendesilva Jan 13, 2023
e283557
Remove the __createdAt meta field from generated JSON
caendesilva Jan 13, 2023
6783f0a
Apply fixes from StyleCI
StyleCIBot Jan 13, 2023
3f9f9a0
Assert the proper templates were published
caendesilva Jan 13, 2023
8f392cc
Format code and clean up presentation
caendesilva Jan 13, 2023
3c85dfe
Refactor code semantics
caendesilva Jan 13, 2023
ec2cc5b
Expect default state to use __createdAt for sorting
caendesilva Jan 13, 2023
6acded3
Merge non-interactive handling to inject default value in normal cont…
caendesilva Jan 13, 2023
be8d899
Introduce local variable and wrap code
caendesilva Jan 13, 2023
d84fa27
Switch order of local variables
caendesilva Jan 13, 2023
a30691d
Inline local variables and format method code
caendesilva Jan 13, 2023
90ed225
Inline local variable
caendesilva Jan 13, 2023
3ef1a3d
Rename inversely named helper method
caendesilva Jan 13, 2023
f2cb6cf
Shorten helper method name
caendesilva Jan 13, 2023
b71b722
Inline variable
caendesilva Jan 13, 2023
6c7bc86
Shift method chain for helper method usage with matching operations
caendesilva Jan 13, 2023
39fc53b
Document method
caendesilva Jan 13, 2023
d20e095
Revert "Document method"
caendesilva Jan 13, 2023
b942341
Inline variable
caendesilva Jan 13, 2023
9902d28
Unwrap offset option from helper method and remote its parameter
caendesilva Jan 13, 2023
8fdfe48
Inline variable
caendesilva Jan 13, 2023
0a2b23c
Apply fixes from StyleCI
StyleCIBot Jan 13, 2023
729c02f
Convert concatenation to 'sprintf()' call
caendesilva Jan 13, 2023
6b6daed
Apply fixes from StyleCI
StyleCIBot Jan 13, 2023
54186c3
Revert "Update virtual page class to support custom closure compiling"
caendesilva Jan 13, 2023
ad7fbad
Merge branch 'integrate-pagination-to-the-publication-type-command' o…
caendesilva Jan 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch order of local variables
  • Loading branch information
caendesilva committed Jan 13, 2023
commit d84fa2741c08a95aa5c6f69471205ffec5182401
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ protected function captureFieldDefinition(): PublicationFieldDefinition

protected function getFieldName(?string $message = null): string
{
$default = $this->input->isInteractive() ? null: 'Example Field';
$message ??= "Enter name for field #{$this->getCount()}";
$default = $this->input->isInteractive() ? null: 'Example Field';

$selected = Str::kebab(trim($this->askWithValidation(
'name', $message, ['required'], default: $default
Expand Down