-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom boolean validation rule with input normalizing #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## publications-feature #835 +/- ##
===========================================================
+ Coverage 99.97% 100.00% +0.02%
+ Complexity 3064 1534 -1530
===========================================================
Files 344 172 -172
Lines 7648 3826 -3822
===========================================================
- Hits 7646 3826 -3820
+ Misses 2 0 -2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short story about solving the right problem
Realized I was trying to solve the wrong problem.
The problem
The problem is/was that when using the
boolean
validation rule from Laravel, the input type must be a boolean. However, the Symfony console input always returns a string. So if you writetrue
to the console, it is interpreted as"true"
, which never validates.The wrong solution
So, I create a custom validation rule to handle booleans. No big deal, but that adds a lot of extra code and possible incompatibility issues.
The (I hope) right solution
Well, the problem is that Laravel expects a certain type right? So why not just convert the input to that type? Well, that's what this PR does. I think it's much more elegant.