Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom boolean validation rule with input normalizing #835

Merged
merged 17 commits into from
Jan 14, 2023

Conversation

caendesilva
Copy link
Member

A short story about solving the right problem

Realized I was trying to solve the wrong problem.

The problem

The problem is/was that when using the boolean validation rule from Laravel, the input type must be a boolean. However, the Symfony console input always returns a string. So if you write true to the console, it is interpreted as "true", which never validates.

The wrong solution

So, I create a custom validation rule to handle booleans. No big deal, but that adds a lot of extra code and possible incompatibility issues.

The (I hope) right solution

Well, the problem is that Laravel expects a certain type right? So why not just convert the input to that type? Well, that's what this PR does. I think it's much more elegant.

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #835 (ee0847d) into publications-feature (d771ae7) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ee0847d differs from pull request most recent head 855f44c. Consider uploading reports for the commit 855f44c to get more accurate results

@@                     Coverage Diff                     @@
##             publications-feature      #835      +/-   ##
===========================================================
+ Coverage                   99.97%   100.00%   +0.02%     
+ Complexity                   3064      1534    -1530     
===========================================================
  Files                         344       172     -172     
  Lines                        7648      3826    -3822     
===========================================================
- Hits                         7646      3826    -3820     
+ Misses                          2         0       -2     
Impacted Files Coverage Δ
...es/publications/src/Commands/ValidatingCommand.php
...rk/src/Framework/Factories/Concerns/HasFactory.php
...rk/src/Console/Commands/PackageDiscoverCommand.php
...amework/src/Framework/Services/MarkdownService.php
packages/framework/src/Facades/Route.php
packages/publications/src/PublicationService.php
...framework/src/Console/Commands/MakePageCommand.php
...kages/framework/src/Markdown/MarkdownConverter.php
...ework/src/Framework/Services/ValidationService.php
packages/framework/src/Support/Facades/Render.php
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 14, 2023 16:38
@caendesilva caendesilva merged commit 94b218b into publications-feature Jan 14, 2023
@caendesilva caendesilva deleted the solve-the-right-problem branch January 14, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants