Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change publication tags to use Yaml instead of Json #837

Merged
merged 13 commits into from
Jan 16, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 15, 2023

Since Yaml is a superset of Json, all Json will still validate. To migrate existing tag files, simply change the .json extension to .yml (example in 2c16bcd)

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #837 (d2fbfad) into publications-feature (7f5876d) will not change coverage.
The diff coverage is n/a.

❗ Current head d2fbfad differs from pull request most recent head 260e477. Consider uploading reports for the commit 260e477 to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature      #837     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   3120      1560   -1560     
==========================================================
  Files                         342       171    -171     
  Lines                        7736      3868   -3868     
==========================================================
- Hits                         7736      3868   -3868     
Impacted Files Coverage Δ
...ckages/publications/src/Models/PublicationTags.php 100.00% <0.00%> (ø)
...blications/src/Commands/MakePublicationCommand.php
...cations/src/Commands/MakePublicationTagCommand.php
...ations/src/Commands/MakePublicationTypeCommand.php
...ckages/publications/src/Models/PublicationTags.php
...k/src/Framework/Factories/FeaturedImageFactory.php
...rc/Framework/Factories/Concerns/CoreDataObject.php
...publications/src/Actions/SeedsPublicationFiles.php
...ork/Features/Metadata/Elements/MetadataElement.php
...ork/src/Foundation/Concerns/ForwardsHyperlinks.php
... and 162 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva changed the title Update publication tags to support Yaml Change publication tags to use Yaml instead of Json Jan 16, 2023
@caendesilva caendesilva force-pushed the refactor-publication-tags branch from 23d7557 to 260e477 Compare January 16, 2023 10:58
@caendesilva caendesilva marked this pull request as ready for review January 16, 2023 11:01
@caendesilva caendesilva merged commit 76ebcdf into publications-feature Jan 16, 2023
@caendesilva caendesilva deleted the refactor-publication-tags branch January 16, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants