Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a publication type validation command and helpers #841

Merged
merged 50 commits into from
Jan 18, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 18, 2023

About

Adds a new php hyde validate:publicationTypes command, as well as surrounding helper methods in the type class and the bulk logic in the service class. The validation is run using the Laravel Validation helpers, which provides a standardized output array format that is used in the presentation layer of the command which invokes it.

Screenshot

image

@caendesilva caendesilva changed the title Add a publication type validation command Add a publication type validation command and helpers Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #841 (858469c) into publications-feature (e921f61) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature      #841     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   3122      1585   -1537     
==========================================================
  Files                         342       172    -170     
  Lines                        7744      3954   -3790     
==========================================================
- Hits                         7744      3954   -3790     
Impacted Files Coverage Δ
...p/packages/publications/src/PublicationService.php 100.00% <0.00%> (ø)
...ckages/publications/src/Models/PublicationType.php 100.00% <0.00%> (ø)
...s/publications/src/PublicationsServiceProvider.php 100.00% <0.00%> (ø)
...ckages/publications/src/Models/PublicationType.php
packages/publications/src/PublicationService.php
...s/publications/src/PublicationsServiceProvider.php
packages/publications/src/Actions/CreateAction.php
...mework/src/Console/Commands/BuildSearchCommand.php
...mework/Features/Session/SessionServiceProvider.php
...rk/src/Framework/Features/Metadata/MetadataBag.php
... and 165 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the publication-type-validation branch from 0f1ec3f to dee1660 Compare January 18, 2023 12:54
@caendesilva caendesilva marked this pull request as ready for review January 18, 2023 12:59
@caendesilva caendesilva merged commit febfaae into publications-feature Jan 18, 2023
@caendesilva caendesilva deleted the publication-type-validation branch January 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants